Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4374)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 1894973005: Don't clear metrics_client_id on shutdown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 9d05aded9bbc3f4298c82196522f5ac6838d50b9..ed4fe07e3de76fd0b621c1c19d21b31f16e43770 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -236,7 +236,10 @@ void ChromeMetricsServiceClient::SetMetricsClientId(
}
void ChromeMetricsServiceClient::OnRecordingDisabled() {
- crash_keys::ClearMetricsClientId();
+ // If we're shutting down, don't drop the metrics_client_id, so that late
+ // crashes won't lose it.
+ if (!g_browser_process->IsShuttingDown())
+ crash_keys::ClearMetricsClientId();
}
bool ChromeMetricsServiceClient::IsOffTheRecordSessionActive() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698