Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Issue 1894933003: [mojo] Don't CHECK fail when a Mojo channel isn't available for a child process. (Closed)

Created:
4 years, 8 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo] Don't CHECK fail when a Mojo channel isn't available for a child process. This is intended to be a mergable patch for M51. BUG=604106 Committed: https://crrev.com/d432f3e89f5d70c432810b9528d196629c4a50b8 Cr-Commit-Position: refs/heads/master@{#388027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/child/child_thread_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
rockot: As Mojo reviewer. piman: For content owners.
4 years, 8 months ago (2016-04-18 04:24:08 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-18 15:21:02 UTC) #3
piman
lgtm
4 years, 8 months ago (2016-04-18 16:03:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894933003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894933003/1
4 years, 8 months ago (2016-04-18 21:08:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 21:15:56 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 21:18:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d432f3e89f5d70c432810b9528d196629c4a50b8
Cr-Commit-Position: refs/heads/master@{#388027}

Powered by Google App Engine
This is Rietveld 408576698