Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: content/child/child_thread_impl.cc

Issue 1894933003: [mojo] Don't CHECK fail when a Mojo channel isn't available for a child process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/child_thread_impl.cc
diff --git a/content/child/child_thread_impl.cc b/content/child/child_thread_impl.cc
index 173fb08441cf43f5c35897370cdbed344a2e8acd..afbdfad79f21ca8ec72f15f12781c8eb0f3f9521 100644
--- a/content/child/child_thread_impl.cc
+++ b/content/child/child_thread_impl.cc
@@ -236,7 +236,10 @@ void InitializeMojoIPCChannel() {
platform_channel.reset(mojo::edk::PlatformHandle(
base::GlobalDescriptors::GetInstance()->Get(kMojoIPCChannel)));
#endif
- CHECK(platform_channel.is_valid());
+ // Mojo isn't supported on all child process types.
+ // TODO(crbug.com/604282): Support Mojo in the remaining processes.
+ if (!platform_channel.is_valid())
+ return;
mojo::edk::SetParentPipeHandle(std::move(platform_channel));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698