Do not prompt for passwords

gclient_scm.py

Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index a299bc26427480fa5e3f205bc9b359b3eb7cc6c5..3a9e90ed6d55c5558464ddd0720f5eac12effab5 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -1030,6 +1030,10 @@ class GitWrapper(SCMWrapper):
       kwargs['filter_fn'] = GitFilter(kwargs['nag_timer'] / 2,
                                       kwargs.get('filter_fn'))
       kwargs.setdefault('print_stdout', False)
+      # Don't prompt for passwords; just fail quickly and noisily.

[Isaac (away), 2013/07/09 21:54:58]

only if jobs > 1 ?

[szager1, 2013/07/09 22:23:09]

Hmm... My concern here is that if we surface the password prompt, people will
think that's the "right" way to do it.  I think I prefer showing them the error
message which steers them to the new-password flow.

I'm not entirely convinced, though; anyone else have an opinion?

+      env = kwargs.get('env') or kwargs.setdefault('env', os.environ.copy())
+      env.setdefault('GIT_ASKPASS', 'true')
+      env.setdefault('SSH_ASKPASS', 'true')

[Dirk Pranke, 2013/07/10 00:26:35]

I think you should have a comment here explaining what this does and why we need
it; it's not at all obvious.

     else:
       kwargs.setdefault('print_stdout', True)
     stdout = kwargs.get('stdout', sys.stdout)