Do not prompt for passwords

gclient_scm.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Gclient-specific SCM-specific operations."""
 
 import collections
 import logging
 import os
 import posixpath
@@ skipping 1012 matching lines @@
           backoff_time *= 1.3
 
   def _Run(self, args, _options, git_filter=False, **kwargs):
     kwargs.setdefault('cwd', self.checkout_path)
     kwargs.setdefault('nag_timer', self.nag_timer)
     kwargs.setdefault('nag_max', self.nag_max)
     if git_filter:
       kwargs['filter_fn'] = GitFilter(kwargs['nag_timer'] / 2,
                                       kwargs.get('filter_fn'))
       kwargs.setdefault('print_stdout', False)
+      # Don't prompt for passwords; just fail quickly and noisily.

[Isaac (away), 2013/07/09 21:54:58]

only if jobs > 1 ?

[szager1, 2013/07/09 22:23:09]

Hmm... My concern here is that if we surface the password prompt, people will
think that's the "right" way to do it.  I think I prefer showing them the error
message which steers them to the new-password flow.

I'm not entirely convinced, though; anyone else have an opinion?

+      env = kwargs.get('env') or kwargs.setdefault('env', os.environ.copy())
+      env.setdefault('GIT_ASKPASS', 'true')
+      env.setdefault('SSH_ASKPASS', 'true')

[Dirk Pranke, 2013/07/10 00:26:35]

I think you should have a comment here explaining what this does and why we need
it; it's not at all obvious.

     else:
       kwargs.setdefault('print_stdout', True)
     stdout = kwargs.get('stdout', sys.stdout)
     stdout.write('\n________ running \'git %s\' in \'%s\'\n' % (
                  ' '.join(args), kwargs['cwd']))
     gclient_utils.CheckCallAndFilter(['git'] + args, **kwargs)
 
 
 class SVNWrapper(SCMWrapper):
   """ Wrapper for SVN """
@@ skipping 378 matching lines @@
       new_command.append('--force')
       if command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
         new_command.extend(('--accept', 'theirs-conflict'))
     elif options.manually_grab_svn_rev:
       new_command.append('--force')
       if command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
         new_command.extend(('--accept', 'postpone'))
     elif command[0] != 'checkout' and scm.SVN.AssertVersion('1.6')[0]:
       new_command.extend(('--accept', 'postpone'))
     return new_command