Remove implicit update when adding a listener in passwords private API.

Remove implicit update when adding a listener in passwords private API.

BUG=598826
Committed: https://crrev.com/4b56a037727e266fc1515dc8d9cd4e94e15f8f63
Cr-Commit-Position: refs/heads/master@{#388926}

[hcarmona, 2016-04-15 23:51:29]

Description was changed from

==========
Remove implicit update when adding a listener in passwords private API.

BUG=598826
==========

to

==========
Remove implicit update when adding a listener in passwords private API.

BUG=598826
==========

[hcarmona, 2016-04-15 23:51:29]

hcarmona@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, stevenjb@chromium.org

[hcarmona, 2016-04-15 23:53:04]

PTAL, this is the 2nd part to adding the explicit update. This removes the
implicit update and fixes tests to make sure we don't get double updates. Also
updates the md-settings passwords page.

[Devlin, 2016-04-16 00:44:21]

idl lg, but waiting for the other to land for official stamp.

[hcarmona, 2016-04-20 23:23:00]

Patchset #2 (id:20001) has been deleted

[hcarmona, 2016-04-20 23:23:09]

Patchset #2 (id:40001) has been deleted

[hcarmona, 2016-04-20 23:36:44]

Updated, PTAL now that dependency has been resolved. Thanks!

[Devlin, 2016-04-21 00:31:01]

idl lgtm

[stevenjb, 2016-04-21 15:57:26]

https://codereview.chromium.org/1894773002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/1894773002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:31:
onSavedPasswordListChangedCallback: assertNotReached,
The names of these are confusing, and the comments are now a bit misleading.
Could you rename them something like setSavedPasswordListChangedCallback, and
update the comment to say something like 'Request the list of saved passwords
and observe future changes.'

[hcarmona, 2016-04-21 21:17:05]

https://codereview.chromium.org/1894773002/diff/60001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/1894773002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:31:
onSavedPasswordListChangedCallback: assertNotReached,
On 2016/04/21 15:57:26, stevenjb wrote:
> The names of these are confusing, and the comments are now a bit misleading.
> Could you rename them something like setSavedPasswordListChangedCallback, and
> update the comment to say something like 'Request the list of saved passwords
> and observe future changes.'

Done.

[stevenjb, 2016-04-21 21:19:15]

Thanks! lgtm

[hcarmona, 2016-04-21 21:27:28]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-04-21 21:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1894773002/#ps80001
(title: "feedback")

[commit-bot: I haz the power, 2016-04-21 21:27:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1894773002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1894773002/80001

[commit-bot: I haz the power, 2016-04-21 22:33:03]

Description was changed from

==========
Remove implicit update when adding a listener in passwords private API.

BUG=598826
==========

to

==========
Remove implicit update when adding a listener in passwords private API.

BUG=598826
==========

[commit-bot: I haz the power, 2016-04-21 22:33:04]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:40:34]

Description was changed from

==========
Remove implicit update when adding a listener in passwords private API.

BUG=598826
==========

to

==========
Remove implicit update when adding a listener in passwords private API.

BUG=598826

Committed: https://crrev.com/4b56a037727e266fc1515dc8d9cd4e94e15f8f63
Cr-Commit-Position: refs/heads/master@{#388926}
==========

[commit-bot: I haz the power, 2016-04-22 19:40:36]

Patchset 3 (id:??) landed as
https://crrev.com/4b56a037727e266fc1515dc8d9cd4e94e15f8f63
Cr-Commit-Position: refs/heads/master@{#388926}