Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Issue 1894773002: Remove implicit update when adding a listener in passwords private API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@explicit-password-api-update.gitbr
Patch Set: feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
index 3c2fd2a9398899ade347858ea4e4adb202794fc2..bb89c94a5607de963fa9b69708ce6a843775fa0b 100644
--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc
@@ -24,42 +24,11 @@ PasswordsPrivateEventRouter::PasswordsPrivateEventRouter(
content::BrowserContext* context)
: context_(context),
event_router_(nullptr) {
- // Register with the event router so we know when renderers are listening to
- // our events. We first check and see if there *is* an event router, because
- // some unit tests try to create all context services, but don't initialize
- // the event router first.
event_router_ = EventRouter::Get(context_);
- if (!event_router_)
- return;
-
- event_router_->RegisterObserver(
- this,
- api::passwords_private::OnSavedPasswordsListChanged::kEventName);
- event_router_->RegisterObserver(
- this,
- api::passwords_private::OnPasswordExceptionsListChanged::kEventName);
- event_router_->RegisterObserver(
- this,
- api::passwords_private::OnPlaintextPasswordRetrieved::kEventName);
}
PasswordsPrivateEventRouter::~PasswordsPrivateEventRouter() {}
-void PasswordsPrivateEventRouter::Shutdown() {
- if (event_router_)
- event_router_->UnregisterObserver(this);
-}
-
-void PasswordsPrivateEventRouter::OnListenerAdded(
- const EventListenerInfo& details) {
- PasswordsPrivateDelegate* delegate =
- PasswordsPrivateDelegateFactory::GetForBrowserContext(context_, true);
- if (delegate) {
- delegate->SendSavedPasswordsList();
- delegate->SendPasswordExceptionsList();
- }
-}
-
void PasswordsPrivateEventRouter::OnSavedPasswordsListChanged(
const std::vector<api::passwords_private::PasswordUiEntry>& entries) {
cached_saved_password_parameters_ =

Powered by Google App Engine
This is Rietveld 408576698