Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1894733002: Change scoped_ptr to std::unique_ptr in //net/disk_cache. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
eroman, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, agl, dcheng, eroman, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change scoped_ptr to std::unique_ptr in //net/disk_cache. R=eroman@chromium.org, gavinp@chromium.org BUG=554298 Committed: https://crrev.com/d04b92dd6de3bbe80c94955ac3347523e891f93d Cr-Commit-Position: refs/heads/master@{#387776}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -290 lines) Patch
M net/disk_cache/backend_unittest.cc View 35 chunks +39 lines, -38 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M net/disk_cache/blockfile/backend_worker_v3.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/block_files.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/block_files.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/disk_cache_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/entry_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl_v3.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl_v3.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/in_flight_backend_io.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/index_table_v3.h View 3 chunks +7 lines, -7 lines 0 comments Download
M net/disk_cache/blockfile/index_table_v3.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/index_table_v3_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M net/disk_cache/blockfile/mapped_file.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/mapped_file_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/mapped_file_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/blockfile/rankings.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/blockfile/rankings.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/blockfile/sparse_control.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/sparse_control_v3.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/stats_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M net/disk_cache/cache_creator.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/disk_cache.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.h View 5 chunks +8 lines, -6 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/entry_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/disk_cache/memory/mem_backend_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/memory/mem_entry_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/memory/mem_entry_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/net_log_parameters.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_backend_impl.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.h View 7 chunks +20 lines, -21 lines 0 comments Download
M net/disk_cache/simple/simple_entry_impl.cc View 20 chunks +37 lines, -42 lines 0 comments Download
M net/disk_cache/simple/simple_index.h View 6 chunks +9 lines, -8 lines 0 comments Download
M net/disk_cache/simple/simple_index.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.h View 4 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_index_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/simple/simple_net_log_parameters.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.h View 3 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
Approx 2 more after this one :)
4 years, 8 months ago (2016-04-15 23:10:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894733002/1
4 years, 8 months ago (2016-04-15 23:11:48 UTC) #3
eroman
lgtm
4 years, 8 months ago (2016-04-15 23:40:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894733002/1
4 years, 8 months ago (2016-04-15 23:51:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-16 01:16:59 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 01:18:12 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d04b92dd6de3bbe80c94955ac3347523e891f93d
Cr-Commit-Position: refs/heads/master@{#387776}

Powered by Google App Engine
This is Rietveld 408576698