Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: net/disk_cache/simple/simple_entry_impl.h

Issue 1894733002: Change scoped_ptr to std::unique_ptr in //net/disk_cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/simple/simple_backend_impl.cc ('k') | net/disk_cache/simple/simple_entry_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/simple/simple_entry_impl.h
diff --git a/net/disk_cache/simple/simple_entry_impl.h b/net/disk_cache/simple/simple_entry_impl.h
index 4d41edc00f2c022f21c4b7207379cb681f2973ee..f528bea580225fcef6c362d34b2be3402d76162f 100644
--- a/net/disk_cache/simple/simple_entry_impl.h
+++ b/net/disk_cache/simple/simple_entry_impl.h
@@ -7,12 +7,12 @@
#include <stdint.h>
+#include <memory>
#include <queue>
#include <string>
#include "base/files/file_path.h"
#include "base/memory/ref_counted.h"
-#include "base/memory/scoped_ptr.h"
#include "base/threading/thread_checker.h"
#include "net/base/cache_type.h"
#include "net/base/net_export.h"
@@ -65,7 +65,7 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,
net::NetLog* net_log);
void SetActiveEntryProxy(
- scoped_ptr<ActiveEntryProxy> active_entry_proxy);
+ std::unique_ptr<ActiveEntryProxy> active_entry_proxy);
// Adds another reader/writer to this entry, if possible, returning |this| to
// |entry|.
@@ -219,7 +219,7 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,
void CreationOperationComplete(
const CompletionCallback& completion_callback,
const base::TimeTicks& start_time,
- scoped_ptr<SimpleEntryCreationResults> in_results,
+ std::unique_ptr<SimpleEntryCreationResults> in_results,
Entry** out_entry,
net::NetLog::EventType end_event_type);
@@ -232,35 +232,35 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,
// |completion_callback| after updating state and dooming on errors.
void EntryOperationComplete(const CompletionCallback& completion_callback,
const SimpleEntryStat& entry_stat,
- scoped_ptr<int> result);
+ std::unique_ptr<int> result);
// Called after an asynchronous read. Updates |crc32s_| if possible.
void ReadOperationComplete(int stream_index,
int offset,
const CompletionCallback& completion_callback,
- scoped_ptr<uint32_t> read_crc32,
- scoped_ptr<SimpleEntryStat> entry_stat,
- scoped_ptr<int> result);
+ std::unique_ptr<uint32_t> read_crc32,
+ std::unique_ptr<SimpleEntryStat> entry_stat,
+ std::unique_ptr<int> result);
// Called after an asynchronous write completes.
void WriteOperationComplete(int stream_index,
const CompletionCallback& completion_callback,
- scoped_ptr<SimpleEntryStat> entry_stat,
- scoped_ptr<int> result);
+ std::unique_ptr<SimpleEntryStat> entry_stat,
+ std::unique_ptr<int> result);
void ReadSparseOperationComplete(
const CompletionCallback& completion_callback,
- scoped_ptr<base::Time> last_used,
- scoped_ptr<int> result);
+ std::unique_ptr<base::Time> last_used,
+ std::unique_ptr<int> result);
void WriteSparseOperationComplete(
const CompletionCallback& completion_callback,
- scoped_ptr<SimpleEntryStat> entry_stat,
- scoped_ptr<int> result);
+ std::unique_ptr<SimpleEntryStat> entry_stat,
+ std::unique_ptr<int> result);
void GetAvailableRangeOperationComplete(
const CompletionCallback& completion_callback,
- scoped_ptr<int> result);
+ std::unique_ptr<int> result);
// Called after an asynchronous doom completes.
void DoomOperationComplete(const CompletionCallback& callback,
@@ -270,11 +270,10 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,
// Called after validating the checksums on an entry. Passes through the
// original result if successful, propagates the error if the checksum does
// not validate.
- void ChecksumOperationComplete(
- int stream_index,
- int orig_result,
- const CompletionCallback& completion_callback,
- scoped_ptr<int> result);
+ void ChecksumOperationComplete(int stream_index,
+ int orig_result,
+ const CompletionCallback& completion_callback,
+ std::unique_ptr<int> result);
// Called after completion of asynchronous IO and receiving file metadata for
// the entry in |entry_stat|. Updates the metadata in the entry and in the
@@ -304,7 +303,7 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,
int length,
int stream_index);
- scoped_ptr<ActiveEntryProxy> active_entry_proxy_;
+ std::unique_ptr<ActiveEntryProxy> active_entry_proxy_;
// All nonstatic SimpleEntryImpl methods should always be called on the IO
// thread, in all cases. |io_thread_checker_| documents and enforces this.
@@ -366,7 +365,7 @@ class NET_EXPORT_PRIVATE SimpleEntryImpl : public Entry,
net::BoundNetLog net_log_;
- scoped_ptr<SimpleEntryOperation> executing_operation_;
+ std::unique_ptr<SimpleEntryOperation> executing_operation_;
// Unlike other streams, stream 0 data is read from the disk when the entry is
// opened, and then kept in memory. All read/write operations on stream 0
« no previous file with comments | « net/disk_cache/simple/simple_backend_impl.cc ('k') | net/disk_cache/simple/simple_entry_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698