Generate the isSVG*Element() / toSVG*Element() helper functions

Generate the isSVG*Element() / toSVG*Element() helper functions

Generate the isSVG*Element() / toSVG*Element() helper functions, similarly to
the HTML ones. This also makes the new Traversal<> API work for SVG Elements.

R=esprehn, pdr
BUG=346095
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168778

[eseidel, 2014-03-07 23:49:27]

lgtm

This is amazing.

My only question is binary size.  If I were you I would do a quick check
before/after your patch just to make sure you're not adding a MB to the chrome
binary, etc.

[eseidel, 2014-03-07 23:50:16]

Really I shouldn't need to ask you to check your binary size contribution.  We
shuld have a TryBot which helps you with that.

[pdr., 2014-03-07 23:52:07]

On 2014/03/07 18:42:44, Chris Dumez wrote:

I think this is absolutely the right direction. I wish we had done this in the
first place, unlike the direction Gyuyoung took. LGTM^2

[Inactive, 2014-03-07 23:55:44]

On 2014/03/07 23:49:27, eseidel wrote:
> lgtm
> 
> This is amazing.
> 
> My only question is binary size.  If I were you I would do a quick check
> before/after your patch just to make sure you're not adding a MB to the chrome
> binary, etc.

No problem, I'll check.

[Inactive, 2014-03-08 00:47:03]

On 2014/03/07 23:55:44, Chris Dumez wrote:
> On 2014/03/07 23:49:27, eseidel wrote:
> > lgtm
> > 
> > This is amazing.
> > 
> > My only question is binary size.  If I were you I would do a quick check
> > before/after your patch just to make sure you're not adding a MB to the
chrome
> > binary, etc.
> 
> No problem, I'll check.

The binary size increase is minimal: 512 bytes in release. Good to go?

[pdr., 2014-03-08 00:49:08]

On 2014/03/08 00:47:03, Chris Dumez wrote:
> On 2014/03/07 23:55:44, Chris Dumez wrote:
> > On 2014/03/07 23:49:27, eseidel wrote:
> > > lgtm
> > > 
> > > This is amazing.
> > > 
> > > My only question is binary size.  If I were you I would do a quick check
> > > before/after your patch just to make sure you're not adding a MB to the
> chrome
> > > binary, etc.
> > 
> > No problem, I'll check.
> 
> The binary size increase is minimal: 512 bytes in release. Good to go?

Great to go :)

This is a security win on several fronts.

[Inactive, 2014-03-08 00:49:55]

The CQ bit was checked by ch.dumez@samsung.com

[eseidel, 2014-03-08 01:10:41]

Lgtm again. :). Go go go!

On Friday, March 7, 2014, <pdr@chromium.org> wrote:

> On 2014/03/08 00:47:03, Chris Dumez wrote:
>
>> On 2014/03/07 23:55:44, Chris Dumez wrote:
>> > On 2014/03/07 23:49:27, eseidel wrote:
>> > > lgtm
>> > >
>> > > This is amazing.
>> > >
>> > > My only question is binary size.  If I were you I would do a quick
>> check
>> > > before/after your patch just to make sure you're not adding a MB to
>> the
>> chrome
>> > > binary, etc.
>> >
>> > No problem, I'll check.
>>
>
>  The binary size increase is minimal: 512 bytes in release. Good to go?
>>
>
> Great to go :)
>
> This is a security win on several fronts.
>
> https://codereview.chromium.org/189463005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-03-08 03:44:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/189463005/20001

[commit-bot: I haz the power, 2014-03-08 10:29:25]

Change committed as 168778