Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: Source/build/scripts/templates/ElementTypeHelpers.h.tmpl

Issue 189463005: Generate the isSVG*Element() / toSVG*Element() helper functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove blank line change Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/build/scripts/make_element_type_helpers.py ('k') | Source/core/core_generated.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
diff --git a/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl b/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
index 91758aa6e889d33a584bb2efb6a3ad4de8dc5967..44fabd26fff88cabf286da7977e60365941a8549 100644
--- a/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
+++ b/Source/build/scripts/templates/ElementTypeHelpers.h.tmpl
@@ -11,7 +11,7 @@
namespace WebCore {
// Type checking.
-{% for tag in tags|sort if not tag.multipleTagNames %}
+{% for tag in tags|sort if not tag.multipleTagNames and not tag.noTypeHelpers %}
class {{tag.interface}};
void is{{tag.interface}}(const {{tag.interface}}&); // Catch unnecessary runtime check of type known at compile time.
void is{{tag.interface}}(const {{tag.interface}}*); // Catch unnecessary runtime check of type known at compile time.
@@ -24,7 +24,7 @@ inline bool is{{tag.interface}}(const Element& element) {
if (!RuntimeEnabledFeatures::{{tag.runtimeEnabled}}Enabled())
return false;
{%- endif %}
- return element.hasTagName({{namespace}}Names::{{tag.name}}Tag);
+ return element.hasTagName({{namespace}}Names::{{tag|symbol}}Tag);
}
inline bool is{{tag.interface}}(const Element* element) { ASSERT(element); return is{{tag.interface}}(*element); }
inline bool is{{tag.interface}}(const Node& node) { return node.isElementNode() ? is{{tag.interface}}(toElement(node)) : false; }
@@ -34,7 +34,7 @@ template <> inline bool isElementOfType<const {{tag.interface}}>(const Element&
// Using macros because the types are forward-declared and we don't want to use reinterpret_cast in the
// casting functions above. reinterpret_cast would be unsafe due to multiple inheritence.
-{% for tag in tags|sort if not tag.multipleTagNames %}
+{% for tag in tags|sort if not tag.multipleTagNames and not tag.noTypeHelpers %}
#define to{{tag.interface}}(x) WebCore::toElement<WebCore::{{tag.interface}}>(x)
{% endfor %}
} // WebCore
« no previous file with comments | « Source/build/scripts/make_element_type_helpers.py ('k') | Source/core/core_generated.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698