Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189453003: Moves around mojo js bindings code (Closed)

Created:
6 years, 9 months ago by sky
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Moves around js bindings related classes The js files ended up in mojo/public/bindings/js The C++ code in mojo/bindings/js Adds a new target with the c++, mojo_js_bindings_lib I'm leaving the unit tests where they are for now, which is not ideal. Will move them in a followup patch. BUG=none TEST=none R=vtl@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -1032 lines) Patch
D mojo/apps/js/bindings/codec.js View 1 chunk +0 lines, -459 lines 0 comments Download
M mojo/apps/js/bindings/codec_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
D mojo/apps/js/bindings/connector.js View 1 chunk +0 lines, -97 lines 0 comments Download
M mojo/apps/js/bindings/connector_unittests.js View 2 chunks +4 lines, -4 lines 0 comments Download
D mojo/apps/js/bindings/core.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/apps/js/bindings/core.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M mojo/apps/js/bindings/core_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/gl/context.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/apps/js/bindings/gl/module.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/apps/js/bindings/handle.h View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/apps/js/bindings/handle.cc View 1 chunk +0 lines, -20 lines 0 comments Download
D mojo/apps/js/bindings/support.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/apps/js/bindings/support.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M mojo/apps/js/bindings/threading.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/apps/js/bindings/waiting_callback.h View 1 chunk +0 lines, -49 lines 0 comments Download
D mojo/apps/js/bindings/waiting_callback.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M mojo/apps/js/main.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/apps/js/mojo_runner_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/apps/js/test/run_js_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/bindings/js/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/bindings/js/core.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/bindings/js/core.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/bindings/js/handle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/bindings/js/handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/bindings/js/support.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/bindings/js/support.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A + mojo/bindings/js/waiting_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + mojo/bindings/js/waiting_callback.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo.gyp View 1 chunk +27 lines, -0 lines 0 comments Download
M mojo/mojo_apps.gypi View 2 chunks +1 line, -8 lines 0 comments Download
M mojo/public/bindings/generators/js_templates/module.js.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/bindings/js/codec.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/bindings/js/connector.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sky
Adam, I didn't make you an official reviewer of this, but if you want to ...
6 years, 9 months ago (2014-03-07 00:25:30 UTC) #1
viettrungluu
lgtm
6 years, 9 months ago (2014-03-07 16:43:24 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-07 16:47:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/189453003/1
6 years, 9 months ago (2014-03-07 16:48:33 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 16:51:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg, mac_chromium_rel
6 years, 9 months ago (2014-03-07 16:51:45 UTC) #6
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-07 16:59:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/189453003/1
6 years, 9 months ago (2014-03-07 17:02:15 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 17:05:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 17:05:01 UTC) #10
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-07 17:28:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/189453003/1
6 years, 9 months ago (2014-03-07 17:30:36 UTC) #12
sky
+jochen for reverse DEPS. I'm TBRing this since this is just copying the deps to ...
6 years, 9 months ago (2014-03-07 18:06:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/189453003/1
6 years, 9 months ago (2014-03-07 20:17:13 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 23:48:35 UTC) #15
Message was sent while issue was closed. 
Change committed as 255716

Powered by Google App Engine
This is Rietveld 408576698