mojo/bindings/js/waiting_callback.cc - Issue 189453003: Moves around mojo js bindings code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/bindings/js/waiting_callback.cc

Issue 189453003: Moves around mojo js bindings code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « mojo/bindings/js/waiting_callback.h ('k') | mojo/mojo.gyp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "mojo/apps/js/bindings/waiting_callback.h"	5 #include "mojo/bindings/js/waiting_callback.h"

6	6

7 #include "gin/per_context_data.h"	7 #include "gin/per_context_data.h"

8	8

9 namespace mojo {	9 namespace mojo {

10 namespace js {	10 namespace js {

11	11

12 namespace {	12 namespace {

13	13

14 v8::Handle<v8::String> GetHiddenPropertyName(v8::Isolate* isolate) {	14 v8::Handle<v8::String> GetHiddenPropertyName(v8::Isolate* isolate) {

15 return gin::StringToSymbol(isolate, "::mojo::js::WaitingCallback");	15 return gin::StringToSymbol(isolate, "::mojo::js::WaitingCallback");

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 GetWrapper(isolate)->GetHiddenValue(GetHiddenPropertyName(isolate));	54 GetWrapper(isolate)->GetHiddenValue(GetHiddenPropertyName(isolate));

55 v8::Handle<v8::Function> callback;	55 v8::Handle<v8::Function> callback;

56 CHECK(gin::ConvertFromV8(isolate, hidden_value, &callback));	56 CHECK(gin::ConvertFromV8(isolate, hidden_value, &callback));

57	57

58 v8::Handle<v8::Value> args[] = { gin::ConvertToV8(isolate, result) };	58 v8::Handle<v8::Value> args[] = { gin::ConvertToV8(isolate, result) };

59 runner_->Call(callback, runner_->global(), 1, args);	59 runner_->Call(callback, runner_->global(), 1, args);

60 }	60 }

61	61

62 } // namespace js	62 } // namespace js

63 } // namespace mojo	63 } // namespace mojo

OLD	NEW