Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: ui/views/controls/button/image_button.h

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/image_button.h
diff --git a/ui/views/controls/button/image_button.h b/ui/views/controls/button/image_button.h
index 79e84d7d3e1a16682433ef83c118035ecbb10be1..9131ae25aaa7a77ccd41f24ba014913af266cd35 100644
--- a/ui/views/controls/button/image_button.h
+++ b/ui/views/controls/button/image_button.h
@@ -20,9 +20,8 @@ class Painter;
// An image button.
tapted 2016/04/20 06:05:58 this line should either be removed or be just `//`
karandeepb 2016/05/03 02:54:12 Sorry it isn't clear to me which line you are talk
tapted 2016/05/03 08:08:25 The comment "// An image button." is currently 'de
karandeepb 2016/05/04 01:56:38 Done.
// Note that this type of button is not focusable by default and will not be
-// part of the focus chain. Call SetFocusBehavior(FocusBehavior::ALWAYS) to
-// make it part of the focus chain.
-
+// part of the focus chain, unless in accessibility mode. Call
+// Button::ConfigureDefaultFocus() to make it part of the focus chain.
class VIEWS_EXPORT ImageButton : public CustomButton {
public:
static const char kViewClassName[];

Powered by Google App Engine
This is Rietveld 408576698