MacViews: Implement Full Keyboard Access.

ui/base/test/scoped_fake_full_keyboard_access.mm

Index: ui/base/test/scoped_fake_full_keyboard_access.mm
diff --git a/ui/base/test/scoped_fake_full_keyboard_access.mm b/ui/base/test/scoped_fake_full_keyboard_access.mm
new file mode 100644
index 0000000000000000000000000000000000000000..eac55f261e0ae35a58e2cce8bd54d52ce26f1ed1
--- /dev/null
+++ b/ui/base/test/scoped_fake_full_keyboard_access.mm
@@ -0,0 +1,45 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ui/base/test/scoped_fake_full_keyboard_access.h"
+
+#import <Cocoa/Cocoa.h>
+
+#import "base/mac/scoped_objc_class_swizzler.h"
+
+namespace {
+
+bool g_full_keyboard_access_mode = false;

[tapted, 2016/04/20 06:05:57]

A lot of tests depend on traversing or setting focus to particular things - we
need to make sure that that behaviour doesn't depend on a system setting on the
particular machine a test is running on.

So I think this should default to "true" -- that will make it more consistent
across platforms. But also the ScopedFakeFullKeyboardAccess should be
"installed" by default for most of the UI tests -- probably into
ViewsTestHelperMac where the focus faker is already.

[karandeepb, 2016/05/03 02:54:12]

Yeah I didn't take into account that these tests may depend on system setting.
Done.

+
+}  // namespace
+
+// Donates testing implementation of [NSApp isFullKeyboardAccessEnabled].

[tapted, 2016/04/20 06:05:57]

nit: testing -> a testing

[karandeepb, 2016/05/03 02:54:12]

Done.

+@interface FakeNSAppKeyboardAccessDonor : NSObject
+@end
+
+@implementation FakeNSAppKeyboardAccessDonor
+
+- (BOOL)isFullKeyboardAccessEnabled {
+  return g_full_keyboard_access_mode;
+}
+
+@end
+
+namespace ui {
+namespace test {
+
+ScopedFakeFullKeyboardAccess::ScopedFakeFullKeyboardAccess()
+    : swizzler_(new base::mac::ScopedObjCClassSwizzler(
+          [NSApplication class],
+          [FakeNSAppKeyboardAccessDonor class],
+          @selector(isFullKeyboardAccessEnabled))) {}
+
+ScopedFakeFullKeyboardAccess::~ScopedFakeFullKeyboardAccess() {}
+
+void ScopedFakeFullKeyboardAccess::SetFullKeyboardAccessState(bool new_state) {
+  g_full_keyboard_access_mode = new_state;

[tapted, 2016/04/20 06:05:57]

we need to test the notifications too. That is, when changing, this should
broadcast out to NSDistributedNotificationCenter similar to the way the
fullscreen faker does

[karandeepb, 2016/05/03 02:54:12]

I can't get broadcasting notifications to NSDistributedNotificationCenter to
work. I am not sure why. The doc for NSDistributedNotificationCenter says - "The
NSDistributedNotificationCenter class provides a way to send notifications to
objects in other tasks. It takes NSNotification objects and broadcasts them to
any objects in other tasks that have registered for the notification with their
task’s default distributed notification center." I am guessing notifications
sent via NSDistributedNotificationCenter are not broadcasted to the broadcasting
application, but only to other interested applications. Maybe we can simulate an
actual Ctrl+F7 key press?

[tapted, 2016/05/03 08:08:25]

Hum - that starts to get into the realms of things that would need an
interactive_ui_test. I think this is OK - hopefully
NSDistributedNotificationCenter won't come up too often.

+}
+
+}  // namespace test
+}  // namespace ui