ash/system/tray/tray_popup_header_button.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/tray/tray_popup_header_button.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Rebased. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/tray/tray_popup_header_button.cc

diff --git a/ash/system/tray/tray_popup_header_button.cc b/ash/system/tray/tray_popup_header_button.cc

index 5947617cc1217311b013b11c2b35f9fee925d560..4743a5b9b0668dc6e87b050a4daa71b102da56d1 100644

--- a/ash/system/tray/tray_popup_header_button.cc

+++ b/ash/system/tray/tray_popup_header_button.cc

@@ -35,7 +35,7 @@ TrayPopupHeaderButton::TrayPopupHeaderButton(views::ButtonListener* listener,

SetImageAlignment(views::ImageButton::ALIGN_CENTER,

views::ImageButton::ALIGN_MIDDLE);

SetAccessibleName(bundle.GetLocalizedString(accessible_name_id));

- SetFocusBehavior(FocusBehavior::ALWAYS);

+ views::Button::ConfigureDefaultFocus(this);

tapted 2016/04/20 06:05:57 if |this| inherits from button, there shouldn't be

karandeepb 2016/05/03 02:54:12 Done. But I have kept the Button:: prefix, since i

set_request_focus_on_press(false);

SetFocusPainter(views::Painter::CreateSolidFocusPainter(

« ash/shell/lock_view.cc ('K') | « ash/shell/lock_view.cc ('k') | ash/system/tray/tray_popup_label_button.cc » ('j') | ui/base/test/scoped_fake_full_keyboard_access.mm » ('J')