chrome/browser/ui/views/website_settings/permission_selector_view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Rebased. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/system/tray/tray_popup_header_button.cc ('K') | « chrome/browser/ui/views/website_settings/chosen_object_view.cc ('k') | ui/app_list/views/folder_header_view.cc » ('j') | ui/base/test/scoped_fake_full_keyboard_access.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

index 91ddd972a05a502255e7304631a0792299ea51af..5e4b84c8531c55c256f767a1e622e7c64756e37b 100644

--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc

+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

@@ -178,7 +178,7 @@ PermissionSelectorView::PermissionSelectorView(

permission.source),

menu_model_.get(), button_enabled);

menu_button_->SetEnabled(button_enabled);

- menu_button_->SetFocusBehavior(FocusBehavior::ALWAYS);

+ views::Button::ConfigureDefaultFocus(menu_button_);

menu_button_->SetAccessibleName(

WebsiteSettingsUI::PermissionTypeToUIString(permission.type));

layout->AddView(menu_button_);