chrome/browser/ui/views/infobars/infobar_view.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/find_bar_view.cc ('k') | chrome/browser/ui/views/location_bar/location_icon_view.cc » ('j') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/infobars/infobar_view.cc

diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc

index 567700777bcb40eae7b19ccf2b46c02cc19bbc0d..a804f4b5404e629b25ff184b071240cd228e1cca 100644

--- a/chrome/browser/ui/views/infobars/infobar_view.cc

+++ b/chrome/browser/ui/views/infobars/infobar_view.cc

@@ -160,7 +160,7 @@ views::LabelButton* InfoBarView::CreateTextButton(

button->set_animate_on_state_change(false);

ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();

button->SetFontList(rb.GetFontList(ui::ResourceBundle::MediumFont));

- button->SetFocusBehavior(FocusBehavior::ALWAYS);

+ views::Button::ConfigureDefaultFocus(button);

button->SetTextColor(views::Button::STATE_NORMAL, GetInfobarTextColor());

button->SetTextColor(views::Button::STATE_HOVERED, GetInfobarTextColor());

return button;

@@ -289,7 +289,7 @@ void InfoBarView::ViewHierarchyChanged(

}

close_button_->SetAccessibleName(

l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE));

- close_button_->SetFocusBehavior(FocusBehavior::ALWAYS);

+ views::Button::ConfigureDefaultFocus(close_button_);

// Subclasses should already be done adding child views by this point (see

// related DCHECK in Layout()).

child_container_->AddChildView(close_button_);