chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/options/wimax_config_view.cc ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('j') | chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

index fb293df4a78120f363899d70ad544d8763d7b666..bc96b315433bc64745a2d4d71c1ddd044fd23e8b 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

@@ -62,7 +62,7 @@ class RevokeButton : public views::ImageButton, public views::ButtonListener {

// Make the button focusable & give it alt-text so permissions can be

// revoked using only the keyboard.

- SetFocusBehavior(FocusBehavior::ALWAYS);

+ Button::ConfigureDefaultFocus(this);

SetTooltipText(l10n_util::GetStringFUTF16(

IDS_APPLICATION_INFO_REVOKE_PERMISSION_ALT_TEXT, permission_message));

}