Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/controls/menu/menu_controller_unittest.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Address review comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/controls/button/button.cc ('K') | « ui/views/controls/link.cc ('k') | ui/views/controls/slider.cc » ('j') | ui/views/focus/focus_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_controller_unittest.cc
diff --git a/ui/views/controls/menu/menu_controller_unittest.cc b/ui/views/controls/menu/menu_controller_unittest.cc
index 5967eae5f83075b367d9bddc542fabcae18e6c56..2dd80af066eba30fde582bf532b85df275900552 100644
--- a/ui/views/controls/menu/menu_controller_unittest.cc
+++ b/ui/views/controls/menu/menu_controller_unittest.cc
@@ -443,6 +443,7 @@ class MenuControllerTest : public ViewsTestBase {
for (int i = 0; i < 3; ++i) {
LabelButton* button =
new LabelButton(nullptr, base::ASCIIToUTF16("Label"));
+ // This is an in-menu button. Hence it must be always focusable.
button->SetFocusBehavior(View::FocusBehavior::ALWAYS);
item_view->AddChildView(button);
}
« ui/views/controls/button/button.cc ('K') | « ui/views/controls/link.cc ('k') | ui/views/controls/slider.cc » ('j') | ui/views/focus/focus_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698