Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: ui/views/controls/button/button.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior
Patch Set: Address review comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/button.cc
diff --git a/ui/views/controls/button/button.cc b/ui/views/controls/button/button.cc
index 9f7e5e283c2542c0a24d6d96e2cc6bce7791add6..5d00e0bff00d4690f61febed98f3600cdd4db0f4 100644
--- a/ui/views/controls/button/button.cc
+++ b/ui/views/controls/button/button.cc
@@ -24,6 +24,16 @@ Button::ButtonState Button::GetButtonStateFrom(ui::NativeTheme::State state) {
return Button::STATE_NORMAL;
}
+// static
+void Button::ConfigureDefaultFocus(Button* button) {
+// On Mac, buttons are focusable only in full keyboard access mode.
tapted 2016/05/03 08:08:25 nit: move this into the #if (then clang-format wil
karandeepb 2016/05/04 01:56:38 Done.
+#if defined(OS_MACOSX)
+ button->SetFocusBehavior(FocusBehavior::ACCESSIBLE_ONLY);
+#else
+ button->SetFocusBehavior(FocusBehavior::ALWAYS);
+#endif
+}
+
////////////////////////////////////////////////////////////////////////////////
// Button, public:

Powered by Google App Engine
This is Rietveld 408576698