ui/views/controls/button/label_button.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/label_button.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/label_button.cc

diff --git a/ui/views/controls/button/label_button.cc b/ui/views/controls/button/label_button.cc

index f2371ea5bc245bdbc9f96eeed07b18f7db030984..0d991cc433d8a8340391adc971892cbb9d9f78e6 100644

--- a/ui/views/controls/button/label_button.cc

+++ b/ui/views/controls/button/label_button.cc

@@ -218,7 +218,7 @@ void LabelButton::SetStyle(ButtonStyle style) {

SetFocusPainter(nullptr);

SetHorizontalAlignment(gfx::ALIGN_CENTER);

- SetFocusBehavior(FocusBehavior::ALWAYS);

+ Button::ConfigureDefaultFocus(this);

SetMinSize(gfx::Size(PlatformStyle::kMinLabelButtonWidth,

PlatformStyle::kMinLabelButtonHeight));

« ui/views/controls/button/button.cc ('K') | « ui/views/controls/button/image_button.h ('k') | ui/views/controls/button/md_text_button.cc » ('j') | ui/views/focus/focus_manager.h » ('J')