ui/views/controls/button/checkbox.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/checkbox.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/checkbox.cc

diff --git a/ui/views/controls/button/checkbox.cc b/ui/views/controls/button/checkbox.cc

index bbc508bdbaa79ff2ef492c6997f59c932424f21f..89cc907220dee6873b2c4f046875d47805960e6e 100644

--- a/ui/views/controls/button/checkbox.cc

+++ b/ui/views/controls/button/checkbox.cc

@@ -28,7 +28,7 @@ Checkbox::Checkbox(const base::string16& label)

// Inset the trailing side by a couple pixels for the focus border.

button_border->set_insets(gfx::Insets(0, 0, 0, 2));

SetBorder(std::move(button_border));

- SetFocusBehavior(FocusBehavior::ALWAYS);

+ Button::ConfigureDefaultFocus(this);

ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();

« ui/views/controls/button/button.cc ('K') | « ui/views/controls/button/button.cc ('k') | ui/views/controls/button/custom_button.h » ('j') | ui/views/focus/focus_manager.h » ('J')