ui/message_center/views/notification_button.cc - Issue 1894383002: MacViews: Implement Full Keyboard Access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/notification_button.cc

Issue 1894383002: MacViews: Implement Full Keyboard Access. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@SetFocusBehavior

Patch Set: Address review comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/base/test/scoped_fake_full_keyboard_access.mm ('K') | « ui/message_center/views/message_center_view.cc ('k') | ui/message_center/views/notifier_settings_view.cc » ('j') | ui/views/controls/button/button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/message_center/views/notification_button.cc

diff --git a/ui/message_center/views/notification_button.cc b/ui/message_center/views/notification_button.cc

index 6eaca0a1b5d2b7b5e42e8d6f77fac1b04b89039d..26a35bfdc0662abaa20234904e6e7ab62ce6f43d 100644

--- a/ui/message_center/views/notification_button.cc

+++ b/ui/message_center/views/notification_button.cc

@@ -23,7 +23,7 @@ NotificationButton::NotificationButton(views::ButtonListener* listener)

focus_painter_(views::Painter::CreateSolidFocusPainter(

message_center::kFocusBorderColor,

gfx::Insets(1, 2, 2, 2))) {

- SetFocusBehavior(FocusBehavior::ALWAYS);

+ Button::ConfigureDefaultFocus(this);

// Create a background so that it does not change when the MessageView

// background changes to show touch feedback

set_background(views::Background::CreateSolidBackground(