third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 1894253002: Prevent sending click event for non primary button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 1894253002: Prevent sending click event for non primary button (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing tests Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index 4a88d4598398c243cde77a02e86ba1b3fd74ad95..74d5da3ece8088b115eaa8fbfe652fdba6dcd103 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -1476,8 +1476,10 @@ WebInputEventResult EventHandler::handleMouseReleaseEvent(const PlatformMouseEve

const bool shouldDispatchClickEvent = m_clickCount > 0

&& !contextMenuEvent

&& mev.innerNode() && m_clickNode

- && mev.innerNode()->canParticipateInFlatTree() && m_clickNode->canParticipateInFlatTree()

- && !(selectionController().hasExtendedSelection() && isLinkSelection(mev));

dtapuska 2016/04/22 18:32:30 This change just seems like formatting...

Navid Zolghadr 2016/04/22 19:09:58 Sure. I change it back to what it was.

+ && mev.innerNode()->canParticipateInFlatTree()

+ && m_clickNode->canParticipateInFlatTree()

+ && !(selectionController().hasExtendedSelection()

+ && isLinkSelection(mev));

if (shouldDispatchClickEvent) {

// Updates distribution because a 'mouseup' event listener can make the

// tree dirty at dispatchMouseEvent() invocation above.