Prevent sending click event for non primary button

third_party/WebKit/Source/core/input/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 1458 matching lines @@
 #if OS(MACOSX)
     // FIXME: The Mac port achieves the same behavior by checking whether the context menu is currently open in WebPage::mouseEvent(). Consider merging the implementations.
     if (mouseEvent.button() == LeftButton && mouseEvent.getModifiers() & PlatformEvent::CtrlKey)
         contextMenuEvent = true;
 #endif
 
     WebInputEventResult clickEventResult = WebInputEventResult::NotHandled;
     const bool shouldDispatchClickEvent = m_clickCount > 0
         && !contextMenuEvent
         && mev.innerNode() && m_clickNode
-        && mev.innerNode()->canParticipateInFlatTree() && m_clickNode->canParticipateInFlatTree()
-        && !(selectionController().hasExtendedSelection() && isLinkSelection(mev));

[dtapuska, 2016/04/22 18:32:30]

This change just seems like formatting...

[Navid Zolghadr, 2016/04/22 19:09:58]

Sure. I change it back to what it was.

+        && mev.innerNode()->canParticipateInFlatTree()
+        && m_clickNode->canParticipateInFlatTree()
+        && !(selectionController().hasExtendedSelection()
+        && isLinkSelection(mev));
     if (shouldDispatchClickEvent) {
         // Updates distribution because a 'mouseup' event listener can make the
         // tree dirty at dispatchMouseEvent() invocation above.
         // Unless distribution is updated, commonAncestor would hit ASSERT.
         // Both m_clickNode and mev.innerNode() don't need to be updated
         // because commonAncestor() will exit early if their documents are different.
         m_clickNode->updateDistribution();
         if (Node* clickTargetNode = mev.innerNode()->commonAncestor(
             *m_clickNode, parentForClickEvent)) {
 
@@ skipping 2658 matching lines @@
 PlatformEvent::Modifiers EventHandler::accessKeyModifiers()
 {
 #if OS(MACOSX)
     return static_cast<PlatformEvent::Modifiers>(PlatformEvent::CtrlKey | PlatformEvent::AltKey);
 #else
     return PlatformEvent::AltKey;
 #endif
 }
 
 } // namespace blink