Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 1894233002: (Reland) [Android] Get package_info by using apk_under_test package. (Closed)

Created:
4 years, 8 months ago by mikecase (-- gone --)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Reland) [Android] Get package_info by using apk_under_test package. Currently, the package_info used by the test apk is looked up by by looking at the test_apk package in the list of package_infos. Instead, we can just look at the package entries in the list of package_infos and compare it to the package of the apk_under_test. This makes things much nicer, when for instance you have multiple test apks targeting the same package. BUG= Committed: https://crrev.com/9454d5d5b562cce1186b398d6afe9cf3b42c08a1 Cr-Commit-Position: refs/heads/master@{#388042}

Patch Set 1 #

Patch Set 2 : Add check to see if _apk_under_test is not None #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -31 lines) Patch
M build/android/pylib/constants/__init__.py View 1 chunk +11 lines, -28 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mikecase (-- gone --)
Got the error... AttributeError: 'NoneType' object has no attribute 'GetPackageName' ...when running Mojo tests. I ...
4 years, 8 months ago (2016-04-18 20:25:48 UTC) #2
agrieve
On 2016/04/18 20:25:48, mikecase wrote: > Got the error... > AttributeError: 'NoneType' object has no ...
4 years, 8 months ago (2016-04-18 20:34:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894233002/20001
4 years, 8 months ago (2016-04-18 20:35:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 22:17:42 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:20:28 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9454d5d5b562cce1186b398d6afe9cf3b42c08a1
Cr-Commit-Position: refs/heads/master@{#388042}

Powered by Google App Engine
This is Rietveld 408576698