Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 1894233002: (Reland) [Android] Get package_info by using apk_under_test package. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add check to see if _apk_under_test is not None Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/constants/__init__.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index cd8617cfc15f7bb84fa79a60caa1a71261dd2de9..e9c33f1c544c7fc9fbac1fc0092b8d9cea6f69a8 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -276,9 +276,11 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._test_runner = self._test_apk.GetInstrumentationName()
self._package_info = None
- for package_info in constants.PACKAGE_INFO.itervalues():
- if self._test_package == package_info.test_package:
- self._package_info = package_info
+ if self._apk_under_test:
+ package_under_test = self._apk_under_test.GetPackageName()
+ for package_info in constants.PACKAGE_INFO.itervalues():
+ if package_under_test == package_info.package:
+ self._package_info = package_info
if not self._package_info:
logging.warning('Unable to find package info for %s', self._test_package)
« no previous file with comments | « build/android/pylib/constants/__init__.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698