Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: media/cast/rtcp/rtcp_sender.h

Issue 189423002: Cast: Cap max receiver log size per rtcp packet to 200 bytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reland patch Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/cast/rtcp/rtcp_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_RTCP_RTCP_SENDER_H_ 5 #ifndef MEDIA_CAST_RTCP_RTCP_SENDER_H_
6 #define MEDIA_CAST_RTCP_RTCP_SENDER_H_ 6 #define MEDIA_CAST_RTCP_RTCP_SENDER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
11 #include "media/cast/cast_config.h" 11 #include "media/cast/cast_config.h"
12 #include "media/cast/cast_defines.h" 12 #include "media/cast/cast_defines.h"
13 #include "media/cast/rtcp/receiver_rtcp_event_subscriber.h" 13 #include "media/cast/rtcp/receiver_rtcp_event_subscriber.h"
14 #include "media/cast/rtcp/rtcp.h" 14 #include "media/cast/rtcp/rtcp.h"
15 #include "media/cast/rtcp/rtcp_defines.h" 15 #include "media/cast/rtcp/rtcp_defines.h"
16 #include "media/cast/transport/cast_transport_defines.h" 16 #include "media/cast/transport/cast_transport_defines.h"
17 #include "media/cast/transport/rtcp/rtcp_builder.h" 17 #include "media/cast/transport/rtcp/rtcp_builder.h"
18 18
19 namespace media { 19 namespace media {
20 namespace cast { 20 namespace cast {
21 21
22 // We limit the size of receiver logs to avoid queuing up packets. We also
23 // do not need the amount of redundancy that results from filling up every
24 // RTCP packet with log messages. This number should give a redundancy of
25 // about 2-3 per log message.
26 const size_t kMaxReceiverLogBytes = 200;
27
22 class ReceiverRtcpEventSubscriber; 28 class ReceiverRtcpEventSubscriber;
23 29
24 // TODO(mikhal): Resolve duplication between this and RtcpBuilder. 30 // TODO(mikhal): Resolve duplication between this and RtcpBuilder.
25 class RtcpSender { 31 class RtcpSender {
26 public: 32 public:
27 RtcpSender(scoped_refptr<CastEnvironment> cast_environment, 33 RtcpSender(scoped_refptr<CastEnvironment> cast_environment,
28 transport::PacedPacketSender* outgoing_transport, 34 transport::PacedPacketSender* outgoing_transport,
29 uint32 sending_ssrc, 35 uint32 sending_ssrc,
30 const std::string& c_name); 36 const std::string& c_name);
31 37
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 // Not owned by this class. 112 // Not owned by this class.
107 transport::PacedPacketSender* const transport_; 113 transport::PacedPacketSender* const transport_;
108 scoped_refptr<CastEnvironment> cast_environment_; 114 scoped_refptr<CastEnvironment> cast_environment_;
109 115
110 DISALLOW_COPY_AND_ASSIGN(RtcpSender); 116 DISALLOW_COPY_AND_ASSIGN(RtcpSender);
111 }; 117 };
112 118
113 } // namespace cast 119 } // namespace cast
114 } // namespace media 120 } // namespace media
115 #endif // MEDIA_CAST_RTCP_RTCP_SENDER_H_ 121 #endif // MEDIA_CAST_RTCP_RTCP_SENDER_H_
OLDNEW
« no previous file with comments | « no previous file | media/cast/rtcp/rtcp_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698