Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 18942002: fix compile warnings (Closed)

Created:
7 years, 5 months ago by humper
Modified:
7 years, 5 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

New bitmap filter checkin; this time with less build breakage BUG= Committed: https://code.google.com/p/skia/source/detail?r=9944

Patch Set 1 : New Bitmap filter checkin; this time with less build breakage #

Patch Set 2 : warning fix #

Patch Set 3 : more warning fixes #

Patch Set 4 : virtual destructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1048 lines, -219 lines) Patch
M bench/BitmapBench.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A bench/BitmapScaleBench.cpp View 1 chunk +135 lines, -0 lines 0 comments Download
M gm/filterbitmap.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
A gm/scalebitmap.cpp View 1 chunk +114 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/opts.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M include/core/SkBitmap.h View 2 chunks +13 lines, -1 line 0 comments Download
M include/core/SkPaint.h View 2 chunks +4 lines, -1 line 0 comments Download
A src/core/SkBitmapFilter.h View 1 2 3 1 chunk +150 lines, -0 lines 0 comments Download
A src/core/SkBitmapFilter.cpp View 1 1 chunk +374 lines, -0 lines 0 comments Download
D src/core/SkBitmapProcBicubic.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
M src/core/SkBitmapProcState.h View 4 chunks +13 lines, -5 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A src/opts/SkBitmapFilter_opts_SSE2.h View 1 chunk +20 lines, -0 lines 0 comments Download
A src/opts/SkBitmapFilter_opts_SSE2.cpp View 1 2 1 chunk +182 lines, -0 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 4 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
humper
7 years, 5 months ago (2013-07-09 21:37:21 UTC) #1
Message was sent while issue was closed.
Committed patchset #4 manually as r9944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698