Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1894103002: 1) Fixing TrackAudioRenderer::Render() to interpret the second parameters as delay in frames, not i… (Closed)

Created:
4 years, 8 months ago by Henrik Grunell
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

1) Fixing TrackAudioRenderer::Render() to interpret the second parameters as delay in frames, not in milliseconds. 2) Changing output buffer size back to "optimal". It was recently changed to use output buffer size in milliseconds, but this does not make much sence, because system (well, at least linux) provides default size in frames and does not care about milliseconds. For example, it can provide default values of 512 for any sample rate. BUG=596174 Review URL: https://codereview.chromium.org/1891183002 Cr-Commit-Position: refs/heads/master@{#387600} (cherry picked from commit 8fc0d951347d29e48a2241173383657869cf506e) Committed: https://chromium.googlesource.com/chromium/src/+/a83ec21846b7ccdf8a85f2c13b40ef12ea43e35c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/renderer/media/track_audio_renderer.cc View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Henrik Grunell
4 years, 8 months ago (2016-04-18 11:46:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a83ec21846b7ccdf8a85f2c13b40ef12ea43e35c.

Powered by Google App Engine
This is Rietveld 408576698