Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1721)

Issue 1891183002: 1) Fixing TrackAudioRenderer::Render() to interpret the second parameters as delay in frames, not i… (Closed)

Created:
4 years, 8 months ago by o1ka
Modified:
4 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, Solis, hlundin-chromium, vanellope-cl_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

1) Fixing TrackAudioRenderer::Render() to interpret the second parameters as delay in frames, not in milliseconds. 2) Changing output buffer size back to "optimal". It was recently changed to use output buffer size in milliseconds, but this does not make much sence, because system (well, at least linux) provides default size in frames and does not care about milliseconds. For example, it can provide default values of 512 for any sample rate. BUG=596174 Committed: https://crrev.com/8fc0d951347d29e48a2241173383657869cf506e Cr-Commit-Position: refs/heads/master@{#387600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/renderer/media/track_audio_renderer.cc View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
o1ka
PTAL. The CL which caused the bug (https://codereview.chromium.org/1687213002) introduced some other inaccuracies (like, in some ...
4 years, 8 months ago (2016-04-15 10:06:47 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 8 months ago (2016-04-15 13:05:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891183002/1
4 years, 8 months ago (2016-04-15 13:10:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 15:04:08 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 15:05:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fc0d951347d29e48a2241173383657869cf506e
Cr-Commit-Position: refs/heads/master@{#387600}

Powered by Google App Engine
This is Rietveld 408576698