Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1894023004: [compiler] Extract scope info installation into helper. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Extract scope info installation into helper. This moves the installation of the scope info object on the shared function info into a separate helper to share common code. This is preparatory work in order to reuse existing scope info objects. R=bmeurer@chromium.org Committed: https://crrev.com/85870e8698780ba836422b23f18e0d4b3d77133a Cr-Commit-Position: refs/heads/master@{#35647}

Patch Set 1 #

Patch Set 2 : Small fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M src/compiler.cc View 1 5 chunks +20 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-19 16:10:59 UTC) #1
Benedikt Meurer
Nice cleanup. LGTM.
4 years, 8 months ago (2016-04-20 04:07:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894023004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894023004/20001
4 years, 8 months ago (2016-04-20 07:50:20 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 08:50:27 UTC) #5
nodir1
4 years, 8 months ago (2016-04-22 18:43:48 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85870e8698780ba836422b23f18e0d4b3d77133a
Cr-Commit-Position: refs/heads/master@{#35647}

Powered by Google App Engine
This is Rietveld 408576698