[compiler] Rename "baseline" to "unoptimized" in pipeline.

[compiler] Rename "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org

Committed: https://crrev.com/2e9920afd0227380deacf1787939f0f675c5c90f
Cr-Commit-Position: refs/heads/master@{#35661}

[Michael Starzinger, 2016-04-19 17:15:56]

Description was changed from

==========
[compiler] Remove "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org
==========

to

==========
[compiler] Rename "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org
==========

[Michael Starzinger, 2016-04-19 17:16:57]

https://codereview.chromium.org/1904463002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1904463002/diff/1/src/compiler.cc#newcode545
src/compiler.cc:545:
counters->total_baseline_code_size()->Increment(CodeAndMetadataSize(info));
Please advise on whether renaming these counters too is a good idea or if they
are already being used by our infrastructure somewhere.

[rmcilroy, 2016-04-20 11:01:53]

LGTM, thanks.

https://codereview.chromium.org/1904463002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1904463002/diff/1/src/compiler.cc#newcode545
src/compiler.cc:545:
counters->total_baseline_code_size()->Increment(CodeAndMetadataSize(info));
On 2016/04/19 17:16:57, Michael Starzinger wrote:
> Please advise on whether renaming these counters too is a good idea or if they
> are already being used by our infrastructure somewhere.

They are used in the v8-perf repo in benchmarks/LoadTime/LoadTime-Ignition.json
and benchmarks/Octane2.1/Octane2.1-Ignition.json. Feel free to just and a TODO
here and I can fix this up.

[Michael Starzinger, 2016-04-20 11:43:11]

Thanks. Addressed comments. Landing.

https://codereview.chromium.org/1904463002/diff/1/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1904463002/diff/1/src/compiler.cc#newcode545
src/compiler.cc:545:
counters->total_baseline_code_size()->Increment(CodeAndMetadataSize(info));
On 2016/04/20 11:01:53, rmcilroy wrote:
> On 2016/04/19 17:16:57, Michael Starzinger wrote:
> > Please advise on whether renaming these counters too is a good idea or if
they
> > are already being used by our infrastructure somewhere.
> 
> They are used in the v8-perf repo in
benchmarks/LoadTime/LoadTime-Ignition.json
> and benchmarks/Octane2.1/Octane2.1-Ignition.json. Feel free to just and a TODO
> here and I can fix this up.

Done. Left a TODO as suggested. Not urgent at all, better not muck with the
measurements right now. I am fine with the name being off if we get nice
contiguous graphs in return. :)

[Michael Starzinger, 2016-04-20 14:09:49]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-04-20 14:09:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1904463002/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-04-20 14:09:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1904463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1904463002/40001

[commit-bot: I haz the power, 2016-04-20 14:11:59]

Description was changed from

==========
[compiler] Rename "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org
==========

to

==========
[compiler] Rename "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org
==========

[commit-bot: I haz the power, 2016-04-20 14:12:00]

Committed patchset #3 (id:40001)

[nodir1, 2016-04-22 18:44:16]

Description was changed from

==========
[compiler] Rename "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org
==========

to

==========
[compiler] Rename "baseline" to "unoptimized" in pipeline.

This is just a pure renaming because "baseline" will be the code name
for our upcoming middle tier within the compilation pipeline. It makes
sure the name "baseline" remains unused.

R=rmcilroy@chromium.org

Committed: https://crrev.com/2e9920afd0227380deacf1787939f0f675c5c90f
Cr-Commit-Position: refs/heads/master@{#35661}
==========

[nodir1, 2016-04-22 18:44:17]

Patchset 3 (id:??) landed as
https://crrev.com/2e9920afd0227380deacf1787939f0f675c5c90f
Cr-Commit-Position: refs/heads/master@{#35661}