Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 1894003002: Merge "DevTools: Do not scroll the console to show the prompt when we select the console tab." to M… (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Merge "DevTools: Do not scroll the console to show the prompt when we select the console tab." to M51 This CL fixes a regression by the behavior change of crrev.com/360545. We'd like to avoid text selection and scrolling in focus() by setting text selection before focus(). BUG=602099 Review URL: https://codereview.chromium.org/1877233002 Cr-Commit-Position: refs/heads/master@{#386751} (cherry picked from commit a31414c359daff0ca68381b7e9625e188cdfbfbf) Committed: https://chromium.googlesource.com/chromium/src/+/198d46b2310aa09d5ac7885607d0829826a8af72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 8 months ago (2016-04-18 01:42:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
198d46b2310aa09d5ac7885607d0829826a8af72.

Powered by Google App Engine
This is Rietveld 408576698