components/test_runner/test_runner.h - Issue 1893783002: Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.h

Issue 1893783002: Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-across-all-renderers

Patch Set: Rebasing... Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/test_runner.h

diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h

index 11ac5a0d8665dffd6a4fc98d57bb1d611c9349fa..ebb22b4408b8f206094bc1caabc905c40b07f50a 100644

--- a/components/test_runner/test_runner.h

+++ b/components/test_runner/test_runner.h

@@ -135,7 +135,9 @@ class TestRunner : public WebTestRunner {

bool shouldDumpSpellCheckCallbacks() const;

bool shouldWaitUntilExternalURLLoad() const;

const std::set<std::string>* httpHeadersToClear() const;

- void setTopLoadingFrame(blink::WebFrame*, bool);

+ bool isFramePartOfMainTestWindow(blink::WebFrame*) const;

+ void tryToSetTopLoadingFrame(blink::WebFrame*);

jochen (gone - plz use gerrit) 2016/04/27 11:59:08 should this and the next return a bool whether it

Łukasz Anforowicz 2016/04/27 17:06:53 Done (+ added comments explaining this and other a

+ void tryToClearTopLoadingFrame(blink::WebFrame*);

blink::WebFrame* topLoadingFrame() const;

void policyDelegateDone();

bool policyDelegateEnabled() const;

« no previous file with comments | « no previous file | components/test_runner/test_runner.cc » ('j') | no next file with comments »