components/test_runner/test_runner.h - Issue 1893783002: Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods.

Side by Side Diff: components/test_runner/test_runner.h

Issue 1893783002: Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-across-all-renderers

Patch Set: Rebasing... Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/test_runner/test_runner.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_	5 #ifndef COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_

6 #define COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_	6 #define COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <deque>	10 #include <deque>

(...skipping 117 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
128 bool shouldDumpTitleChanges() const;	128 bool shouldDumpTitleChanges() const;

129 bool shouldDumpIconChanges() const;	129 bool shouldDumpIconChanges() const;

130 bool shouldDumpCreateView() const;	130 bool shouldDumpCreateView() const;

131 bool canOpenWindows() const;	131 bool canOpenWindows() const;

132 bool shouldDumpResourceLoadCallbacks() const;	132 bool shouldDumpResourceLoadCallbacks() const;

133 bool shouldDumpResourceResponseMIMETypes() const;	133 bool shouldDumpResourceResponseMIMETypes() const;

134 bool shouldDumpStatusCallbacks() const;	134 bool shouldDumpStatusCallbacks() const;

135 bool shouldDumpSpellCheckCallbacks() const;	135 bool shouldDumpSpellCheckCallbacks() const;

136 bool shouldWaitUntilExternalURLLoad() const;	136 bool shouldWaitUntilExternalURLLoad() const;

137 const std::set<std::string>* httpHeadersToClear() const;	137 const std::set<std::string>* httpHeadersToClear() const;

138 void setTopLoadingFrame(blink::WebFrame*, bool);	138 bool isFramePartOfMainTestWindow(blink::WebFrame*) const;

	139 void tryToSetTopLoadingFrame(blink::WebFrame*);
	jochen (gone - plz use gerrit) 2016/04/27 11:59:08 should this and the next return a bool whether it should this and the next return a bool whether it was successful? just for API niceness... Łukasz Anforowicz 2016/04/27 17:06:53 Done (+ added comments explaining this and other a Show quoted text On 2016/04/27 11:59:08, jochen wrote: > should this and the next return a bool whether it was successful? just for API > niceness... Done (+ added comments explaining this and other aspects of the behavior).
	140 void tryToClearTopLoadingFrame(blink::WebFrame*);

139 blink::WebFrame* topLoadingFrame() const;	141 blink::WebFrame* topLoadingFrame() const;

140 void policyDelegateDone();	142 void policyDelegateDone();

141 bool policyDelegateEnabled() const;	143 bool policyDelegateEnabled() const;

142 bool policyDelegateIsPermissive() const;	144 bool policyDelegateIsPermissive() const;

143 bool policyDelegateShouldNotifyDone() const;	145 bool policyDelegateShouldNotifyDone() const;

144 bool shouldInterceptPostMessage() const;	146 bool shouldInterceptPostMessage() const;

145 bool shouldDumpResourcePriorities() const;	147 bool shouldDumpResourcePriorities() const;

146 void setToolTipText(const blink::WebString&);	148 void setToolTipText(const blink::WebString&);

147 void setDragImage(const blink::WebImage& drag_image);	149 void setDragImage(const blink::WebImage& drag_image);

148 bool shouldDumpNavigationPolicy() const;	150 bool shouldDumpNavigationPolicy() const;

(...skipping 679 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
828 WebTestProxyBase* web_test_proxy_base_;	830 WebTestProxyBase* web_test_proxy_base_;

829	831

830 base::WeakPtrFactory<TestRunnerForSpecificView> weak_factory_;	832 base::WeakPtrFactory<TestRunnerForSpecificView> weak_factory_;

831	833

832 DISALLOW_COPY_AND_ASSIGN(TestRunnerForSpecificView);	834 DISALLOW_COPY_AND_ASSIGN(TestRunnerForSpecificView);

833 };	835 };

834	836

835 } // namespace test_runner	837 } // namespace test_runner

836	838

837 #endif // COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_	839 #endif // COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_

OLD	NEW