Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 189373003: Get rid of the formatting code in build_gles2_cmd_buffer.py (Closed)

Created:
6 years, 9 months ago by Zhenyao Mo
Modified:
6 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, teravest+watch_chromium.org, yzshen+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Get rid of the formatting code in build_gles2_cmd_buffer.py Now we use clang-format in the end, so no need to format it before. BUG= TEST=bots R=bajones@chromium.org, dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255666

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -341 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 1 chunk +3 lines, -66 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 3 chunks +6 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 5 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 109 chunks +145 lines, -178 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 19 chunks +33 lines, -33 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 4 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 7 chunks +22 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/c/dev/ppb_opengles2ext_dev.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/ppb_opengles2.h View 4 chunks +10 lines, -10 lines 0 comments Download
M ppapi/lib/gl/gles2/gles2.c View 1 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppb_opengles2_shared.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
bajones: please review. dmichael: ppapi owner approval You only need to take a look at ...
6 years, 9 months ago (2014-03-07 00:38:13 UTC) #1
bajones
On 2014/03/07 00:38:13, Zhenyao Mo wrote: > bajones: please review. > dmichael: ppapi owner approval ...
6 years, 9 months ago (2014-03-07 00:48:06 UTC) #2
dmichael (off chromium)
Awesome, lgtm!
6 years, 9 months ago (2014-03-07 16:24:34 UTC) #3
Zhenyao Mo
6 years, 9 months ago (2014-03-07 18:25:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r255666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698