Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6085)

Unified Diff: chrome/browser/resources/settings/settings_dialog.html

Issue 1893663003: MD Settings: Bring <settings-dialog> closer to dialog spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_dialog.html
diff --git a/chrome/browser/resources/settings/settings_dialog.html b/chrome/browser/resources/settings/settings_dialog.html
index df72a0df54ef14921e24b7ac6c917da8f526e4ed..c58286a295a2291e4d0f105552ec60f4bd829a04 100644
--- a/chrome/browser/resources/settings/settings_dialog.html
+++ b/chrome/browser/resources/settings/settings_dialog.html
@@ -9,8 +9,10 @@
<style include="paper-dialog-shared-styles"></style>
<style>
.body-content {
+ display: flex;
+ flex-direction: column;
font-size: 1em;
- margin: 20px 0;
+ min-height: 120px;
}
.dialog-content {
@@ -27,28 +29,37 @@
.top-row {
align-items: center;
- border-bottom: 1px solid var(--paper-grey-300);
+ border-bottom: 1px solid rgba(0, 0, 0, 0.14);
display: flex;
- padding-bottom: 5px;
- padding-top: 5px;
+ min-height: 52px;
+ }
+
+ paper-icon-button {
+ height: 20px;
+ margin: 16px;
+ padding: 0;
+ width: 20px;
}
:host {
max-width: 800px;
- min-width: 500px;
+ min-width: 512px;
overflow: auto;
}
:host ::content .body {
- margin-bottom: 35px;
+ flex: 1;
+ margin: 12px 0 24px 0;
}
:host ::content .button-container {
display: flex;
justify-content: flex-end;
+ margin-bottom: 12px;
}
:host ::content .button-container .cancel-button {
+ -webkit-margin-end: 8px;
color: var(--paper-grey-600);
font-weight: 500;
}
@@ -71,7 +82,7 @@
:host ::content .title {
flex: 1;
- font-size: 1.13em;
+ font-size: 114.28%; /* (16px / 14px) * 100 */
dpapad 2016/04/18 17:24:26 Per our last week's conversation, I figured out wh
dschuyler 2016/04/18 18:52:52 That sounds right :) So there are a couple options
}
:host ::content .title,
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698