Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Side by Side Diff: chrome/browser/resources/settings/settings_dialog.html

Issue 1893663003: MD Settings: Bring <settings-dialog> closer to dialog spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-behavior.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-behavior.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-shared-styles.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog-behavior/p aper-dialog-shared-styles.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
6 6
7 <dom-module id="settings-dialog"> 7 <dom-module id="settings-dialog">
8 <template> 8 <template>
9 <style include="paper-dialog-shared-styles"></style> 9 <style include="paper-dialog-shared-styles"></style>
10 <style> 10 <style>
11 .body-content { 11 .body-content {
12 display: flex;
13 flex-direction: column;
12 font-size: 1em; 14 font-size: 1em;
13 margin: 20px 0; 15 min-height: 120px;
14 } 16 }
15 17
16 .dialog-content { 18 .dialog-content {
17 -webkit-padding-end: 0; 19 -webkit-padding-end: 0;
18 -webkit-padding-start: 0; 20 -webkit-padding-start: 0;
19 margin-bottom: 0; 21 margin-bottom: 0;
20 margin-top: 0; 22 margin-top: 0;
21 } 23 }
22 24
23 .footer-container { 25 .footer-container {
24 margin: 0; 26 margin: 0;
25 padding: 0; 27 padding: 0;
26 } 28 }
27 29
28 .top-row { 30 .top-row {
29 align-items: center; 31 align-items: center;
30 border-bottom: 1px solid var(--paper-grey-300); 32 border-bottom: 1px solid rgba(0, 0, 0, 0.14);
31 display: flex; 33 display: flex;
32 padding-bottom: 5px; 34 min-height: 52px;
33 padding-top: 5px; 35 }
36
37 paper-icon-button {
38 height: 20px;
39 margin: 16px;
40 padding: 0;
41 width: 20px;
34 } 42 }
35 43
36 :host { 44 :host {
37 max-width: 800px; 45 max-width: 800px;
38 min-width: 500px; 46 min-width: 512px;
39 overflow: auto; 47 overflow: auto;
40 } 48 }
41 49
42 :host ::content .body { 50 :host ::content .body {
43 margin-bottom: 35px; 51 flex: 1;
52 margin: 12px 0 24px 0;
44 } 53 }
45 54
46 :host ::content .button-container { 55 :host ::content .button-container {
47 display: flex; 56 display: flex;
48 justify-content: flex-end; 57 justify-content: flex-end;
58 margin-bottom: 12px;
49 } 59 }
50 60
51 :host ::content .button-container .cancel-button { 61 :host ::content .button-container .cancel-button {
62 -webkit-margin-end: 8px;
52 color: var(--paper-grey-600); 63 color: var(--paper-grey-600);
53 font-weight: 500; 64 font-weight: 500;
54 } 65 }
55 66
56 :host ::content .footer { 67 :host ::content .footer {
57 background-color: var(--paper-grey-200); 68 background-color: var(--paper-grey-200);
58 margin: 0; 69 margin: 0;
59 padding: 20px; 70 padding: 20px;
60 } 71 }
61 72
62 :host ::content .row { 73 :host ::content .row {
63 align-items: center; 74 align-items: center;
64 display: flex; 75 display: flex;
65 min-height: 40px; 76 min-height: 40px;
66 } 77 }
67 78
68 :host ::content .row .start { 79 :host ::content .row .start {
69 flex: 1; 80 flex: 1;
70 } 81 }
71 82
72 :host ::content .title { 83 :host ::content .title {
73 flex: 1; 84 flex: 1;
74 font-size: 1.13em; 85 font-size: 114.28%; /* (16px / 14px) * 100 */
dpapad 2016/04/18 17:24:26 Per our last week's conversation, I figured out wh
dschuyler 2016/04/18 18:52:52 That sounds right :) So there are a couple options
75 } 86 }
76 87
77 :host ::content .title, 88 :host ::content .title,
78 .body-content { 89 .body-content {
79 -webkit-padding-end: 24px; 90 -webkit-padding-end: 24px;
80 -webkit-padding-start: 24px; 91 -webkit-padding-start: 24px;
81 } 92 }
82 </style> 93 </style>
83 <div class="dialog-content"> 94 <div class="dialog-content">
84 <div class="top-row"> 95 <div class="top-row">
85 <content select=".title"></content> 96 <content select=".title"></content>
86 <paper-icon-button icon="clear" on-tap="cancel" id="close"> 97 <paper-icon-button icon="clear" on-tap="cancel" id="close">
87 </paper-icon-button> 98 </paper-icon-button>
88 </div> 99 </div>
89 <div class="body-content"> 100 <div class="body-content">
90 <content select=".body"></content> 101 <content select=".body"></content>
91 <content select=".button-container"></content> 102 <content select=".button-container"></content>
92 </div> 103 </div>
93 </div> 104 </div>
94 <div class="footer-container"> 105 <div class="footer-container">
95 <content select=".footer"></content> 106 <content select=".footer"></content>
96 </div> 107 </div>
97 </template> 108 </template>
98 <script src="settings_dialog.js"></script> 109 <script src="settings_dialog.js"></script>
99 </dom-module> 110 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698