Direct the Settings link to sign in settings screen instead of sync settings screen

Direct the Settings link to sign in settings screen instead of sync settings screen

This CL directs the Settings link in sign in confirmation screen to sign in settings screen instead of sync settings screen.

BUG=595349
Committed: https://crrev.com/8d2c683bd9e3b4c42fd6ba4dc2df00ee26fa6b6d
Cr-Commit-Position: refs/heads/master@{#388541}

[gogerald1, 2016-04-15 16:32:53]

Description was changed from

==========
format


direct setting link to sign in settings screen

BUG=
==========

to

==========
Direct settings link to sign in settings screen instead of sync settings screen

This CL directs the settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349
==========

[gogerald1, 2016-04-15 16:36:20]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 16:36:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893643002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893643002/1

[commit-bot: I haz the power, 2016-04-15 16:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 16:59:08]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)

[gogerald1, 2016-04-15 19:32:08]

Description was changed from

==========
Direct settings link to sign in settings screen instead of sync settings screen

This CL directs the settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349
==========

to

==========
Direct the Settings link to sign in settings screen instead of sync settings
screen

This CL directs the Settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349
==========

[gogerald1, 2016-04-15 19:32:08]

gogerald@chromium.org changed reviewers:
+ bauerb@chromium.org

[gogerald1, 2016-04-15 20:30:54]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-04-15 20:31:07]

PTAL,

[Bernhard Bauer, 2016-04-19 15:13:06]

https://codereview.chromium.org/1893643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
(right):

https://codereview.chromium.org/1893643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java:111:
final boolean mSettingsClicked = settingsClicked;
This should be just called |settingsClicked|.

[gogerald1, 2016-04-19 17:09:31]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 17:10:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893643002/40001

[gogerald1, 2016-04-19 17:12:18]

https://codereview.chromium.org/1893643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java
(right):

https://codereview.chromium.org/1893643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninPromoScreen.java:111:
final boolean mSettingsClicked = settingsClicked;
On 2016/04/19 15:13:06, Bernhard Bauer wrote:
> This should be just called |settingsClicked|.

Done.

[commit-bot: I haz the power, 2016-04-19 17:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 17:58:50]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-04-20 16:50:40]

LGTM with the unnecessary final's removed:

https://codereview.chromium.org/1893643002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
(right):

https://codereview.chromium.org/1893643002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java:74:
public void onAccountSelected(String accountName, final boolean
settingsClicked);
Note that "final" is not part of the interface (it's just a modifier for the
local variable that is the parameter), so it's okay to only mark the parameter
final where needed.

[gogerald1, 2016-04-20 18:10:10]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 18:10:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893643002/60001

[commit-bot: I haz the power, 2016-04-20 18:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 18:50:34]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2016-04-20 18:52:03]

https://codereview.chromium.org/1893643002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java
(right):

https://codereview.chromium.org/1893643002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninView.java:74:
public void onAccountSelected(String accountName, final boolean
settingsClicked);
On 2016/04/20 16:50:40, Bernhard Bauer wrote:
> Note that "final" is not part of the interface (it's just a modifier for the
> local variable that is the parameter), so it's okay to only mark the parameter
> final where needed.

Done.

[gogerald1, 2016-04-20 18:52:54]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-04-20 18:52:54]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1893643002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-20 18:53:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893643002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893643002/60001

[commit-bot: I haz the power, 2016-04-20 18:57:08]

Description was changed from

==========
Direct the Settings link to sign in settings screen instead of sync settings
screen

This CL directs the Settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349
==========

to

==========
Direct the Settings link to sign in settings screen instead of sync settings
screen

This CL directs the Settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349
==========

[commit-bot: I haz the power, 2016-04-20 18:57:09]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:25:07]

Description was changed from

==========
Direct the Settings link to sign in settings screen instead of sync settings
screen

This CL directs the Settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349
==========

to

==========
Direct the Settings link to sign in settings screen instead of sync settings
screen

This CL directs the Settings link in sign in confirmation screen to sign in
settings screen instead of sync settings screen.

BUG=595349

Committed: https://crrev.com/8d2c683bd9e3b4c42fd6ba4dc2df00ee26fa6b6d
Cr-Commit-Position: refs/heads/master@{#388541}
==========

[commit-bot: I haz the power, 2016-04-22 19:25:08]

Patchset 3 (id:??) landed as
https://crrev.com/8d2c683bd9e3b4c42fd6ba4dc2df00ee26fa6b6d
Cr-Commit-Position: refs/heads/master@{#388541}