chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java - Issue 1893643002: Direct the Settings link to sign in settings screen instead of sync settings screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

Issue 1893643002: Direct the Settings link to sign in settings screen instead of sync settings screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

index d4e64f993824ad598bf654627ca4b7db2c66de32..e8d96a2a0ef6799a49adacda2018dbeca81703e5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java

@@ -56,10 +56,10 @@ public interface FirstRunPageDelegate {

void acceptSignIn(String accountName);

/**

- * Notifies that the user asked to show Sync Settings once the sign in

+ * Notifies that the user asked to show sign in Settings once the sign in

* process is complete.

- void askToOpenSyncSettings();

+ void askToOpenSignInSettings();

/**

* @return Whether the user has accepted Chrome Terms of Service.