Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1893613003: Make notification high priority While download is in progress (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Make notification high priority While download is in progress Android only show action buttons when notification is on top of the notification drawer. By setting priority to high, we move the download progress notification to the top drawer. As a result, user can see the action buttons and pause/cancel the active download. This UI change is per discussion with rolfe@ and sidv@. TBR=dtrainor@chromium.org BUG=603229 Review URL: https://codereview.chromium.org/1889443003 Cr-Commit-Position: refs/heads/master@{#387674} (cherry picked from commit 9b87ece5135008a0a046a7b2edf4436d60183144) Committed: https://chromium.googlesource.com/chromium/src/+/d47b3994afdddf2e3d40f510b8c56935c3fcd5ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 8 months ago (2016-04-15 21:32:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d47b3994afdddf2e3d40f510b8c56935c3fcd5ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698