Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1889443003: Make notification high priority While download is in progress (Closed)

Created:
4 years, 8 months ago by qinmin
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make notification high priority While download is in progress Android only show action buttons when notification is on top of the notification drawer. By setting priority to high, we move the download progress notification to the top drawer. As a result, user can see the action buttons and pause/cancel the active download. This UI change is per discussion with rolfe@ and sidv@. BUG=603229 Committed: https://crrev.com/9b87ece5135008a0a046a7b2edf4436d60183144 Cr-Commit-Position: refs/heads/master@{#387674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 8 months ago (2016-04-13 19:26:41 UTC) #2
David Trainor- moved to gerrit
lgtm!
4 years, 8 months ago (2016-04-15 16:02:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1889443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1889443003/1
4 years, 8 months ago (2016-04-15 17:27:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 19:40:03 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 19:41:27 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b87ece5135008a0a046a7b2edf4436d60183144
Cr-Commit-Position: refs/heads/master@{#387674}

Powered by Google App Engine
This is Rietveld 408576698