Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1893513002: Remove the first launch from home screen requirement for notification deep linking. (Closed)

Created:
4 years, 8 months ago by dominickn
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Remove the first launch from home screen requirement for notification deep linking. https://crrev.com/1867543002 implemented notification deep linking for Android, with the requirement that a web app be explicily launched from home screen before it would be permitted to have deep links from notifications. This CL removes this requirement. Now sites which have been added to homescreen OR launched from homescreen within the last ten days are permitted to be deep-linked from a notification. BUG=541711 Review URL: https://codereview.chromium.org/1872983002 Cr-Commit-Position: refs/heads/master@{#386381} (cherry picked from commit b4abc9d04c20c2d83124a1b9cc3960e8f4e48bdb) Committed: https://chromium.googlesource.com/chromium/src/+/0e50cdbeee971718a29c199d76abc10dd6c43e04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -72 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java View 4 chunks +3 lines, -22 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java View 2 chunks +7 lines, -19 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java View 11 chunks +12 lines, -30 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
4 years, 8 months ago (2016-04-15 02:31:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e50cdbeee971718a29c199d76abc10dd6c43e04.

Powered by Google App Engine
This is Rietveld 408576698