Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1872983002: Remove the first launch from home screen requirement for notification deep linking. (Closed)

Created:
4 years, 8 months ago by dominickn
Modified:
4 years, 8 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@deep-link-actual
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the first launch from home screen requirement for notification deep linking. https://crrev.com/1867543002 implemented notification deep linking for Android, with the requirement that a web app be explicily launched from home screen before it would be permitted to have deep links from notifications. This CL removes this requirement. Now sites which have been added to homescreen OR launched from homescreen within the last ten days are permitted to be deep-linked from a notification. BUG=541711 Committed: https://crrev.com/b4abc9d04c20c2d83124a1b9cc3960e8f4e48bdb Cr-Commit-Position: refs/heads/master@{#386381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -72 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java View 4 chunks +3 lines, -22 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java View 2 chunks +7 lines, -19 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappRegistryTest.java View 11 chunks +12 lines, -30 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
dominickn
mlamouri: PTAL at chrome/browser/webapps yfriendman: PTAL at junit/ dfalcantara@ is away this week (he reviewed ...
4 years, 8 months ago (2016-04-11 00:08:29 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 8 months ago (2016-04-11 13:21:56 UTC) #4
Yaron
lgtm
4 years, 8 months ago (2016-04-11 13:57:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1872983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1872983002/1
4 years, 8 months ago (2016-04-11 14:01:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 14:41:00 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 14:42:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4abc9d04c20c2d83124a1b9cc3960e8f4e48bdb
Cr-Commit-Position: refs/heads/master@{#386381}

Powered by Google App Engine
This is Rietveld 408576698