VideoTrackRecorder: extract base class Encoder out of VpxEncoder

VideoTrackRecorder: extract base class Encoder out of VpxEncoder

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
Committed: https://crrev.com/8702c29cb538f4d76a6bde77ee52d8a4350c2c09
Cr-Commit-Position: refs/heads/master@{#387526}

[mcasas, 2016-04-15 00:24:10]

Description was changed from

==========
VideoTrackRecorder: make internal VpxEncoder an Encoder.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

to

==========
VideoTrackRecorder: make internal VpxEncoder an Encoder.

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

[mcasas, 2016-04-15 00:26:17]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-04-15 00:26:24]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-04-15 00:26:38]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org

[mcasas, 2016-04-15 00:26:39]

emircan@ PTAL

[mcasas, 2016-04-15 02:04:14]

Description was changed from

==========
VideoTrackRecorder: make internal VpxEncoder an Encoder.

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

to

==========
VideoTrackRecorder: extract base class Encoder out of VpxEncoder

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

[emircan, 2016-04-15 02:07:10]

lgtm % nits.

https://codereview.chromium.org/1893493003/diff/40001/content/renderer/media/...
File content/renderer/media/video_track_recorder.cc (right):

https://codereview.chromium.org/1893493003/diff/40001/content/renderer/media/...
content/renderer/media/video_track_recorder.cc:46: virtual void
StartFrameEncode(const scoped_refptr<VideoFrame>& frame,
s/StartFrameEncode/EncodeFrame/?

https://codereview.chromium.org/1893493003/diff/40001/content/renderer/media/...
content/renderer/media/video_track_recorder.cc:49: void set_paused(bool paused)
{ paused_ = paused; }
I would rather leave this to the implementation, so that you can use a
thread_checker and make sure that you stop encoding on the correct thread.

[mcasas, 2016-04-15 02:24:46]

On 2016/04/15 02:07:10, emircan wrote:
> lgtm % nits.
> 
>
https://codereview.chromium.org/1893493003/diff/40001/content/renderer/media/...
> File content/renderer/media/video_track_recorder.cc (right):
> 
>
https://codereview.chromium.org/1893493003/diff/40001/content/renderer/media/...
> content/renderer/media/video_track_recorder.cc:46: virtual void
> StartFrameEncode(const scoped_refptr<VideoFrame>& frame,
> s/StartFrameEncode/EncodeFrame/?
> 
>
https://codereview.chromium.org/1893493003/diff/40001/content/renderer/media/...
> content/renderer/media/video_track_recorder.cc:49: void set_paused(bool
paused)
> { paused_ = paused; }
> I would rather leave this to the implementation, so that you can use a
> thread_checker and make sure that you stop encoding on the correct thread.

Those are legit comments. We discussed offline and
will tackle naming and DCHECKING on set_pause() in
the next CL https://crrev.com/1884383002/, so this
CL can stay as simply moving things around with no
new code otherwise.

[mcasas, 2016-04-15 02:24:55]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-04-15 02:25:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893493003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893493003/40001

[commit-bot: I haz the power, 2016-04-15 02:29:09]

Description was changed from

==========
VideoTrackRecorder: extract base class Encoder out of VpxEncoder

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

to

==========
VideoTrackRecorder: extract base class Encoder out of VpxEncoder

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

[commit-bot: I haz the power, 2016-04-15 02:29:11]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-04-15 02:30:32]

Description was changed from

==========
VideoTrackRecorder: extract base class Encoder out of VpxEncoder

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636
==========

to

==========
VideoTrackRecorder: extract base class Encoder out of VpxEncoder

Some common functionality is moved to Encoder from
VpxEncoder. Also VpxEncoder is moved to the anonymous
namespace.

No new code is added, this CL is pure refactoring.

This is the 2nd step in a series of CLs to add support for
H264 to MediaRecorder (see https://crrev.com/1886123002/).
Next step is to add an H264Encoder (<is a> Encoder).

BUG=601636

Committed: https://crrev.com/8702c29cb538f4d76a6bde77ee52d8a4350c2c09
Cr-Commit-Position: refs/heads/master@{#387526}
==========

[commit-bot: I haz the power, 2016-04-15 02:30:33]

Patchset 1 (id:??) landed as
https://crrev.com/8702c29cb538f4d76a6bde77ee52d8a4350c2c09
Cr-Commit-Position: refs/heads/master@{#387526}