Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: content/renderer/media/video_track_recorder.h

Issue 1893493003: VideoTrackRecorder: extract base class Encoder out of VpxEncoder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_track_recorder.h
diff --git a/content/renderer/media/video_track_recorder.h b/content/renderer/media/video_track_recorder.h
index 6478873e6327ad1196d99528d937a7cfaf2dc148..aa2a4b2ec1dfc2a0be32f9f6c78edb0ce9a07de9 100644
--- a/content/renderer/media/video_track_recorder.h
+++ b/content/renderer/media/video_track_recorder.h
@@ -20,11 +20,11 @@ class VideoFrame;
namespace content {
// VideoTrackRecorder is a MediaStreamVideoSink that encodes the video frames
-// received from a Stream Video Track. The class is constructed and used on a
-// single thread, namely the main Render thread. It has an internal VpxEncoder
-// with its own threading subtleties, see the implementation file. This mirrors
-// the other MediaStreamVideo* classes that are constructed/configured on Main
-// Render thread but that pass frames on Render IO thread.
+// received from a Stream Video Track. This class is constructed and used on a
+// single thread, namely the main Render thread. This mirrors the other
+// MediaStreamVideo* classes that are constructed/configured on Main Render
+// thread but that pass frames on Render IO thread. It has an internal Encoder
+// with its own threading subtleties, see the implementation file.
class CONTENT_EXPORT VideoTrackRecorder
: NON_EXPORTED_BASE(public MediaStreamVideoSink) {
public:
@@ -32,6 +32,7 @@ class CONTENT_EXPORT VideoTrackRecorder
VP8,
VP9,
};
+ class Encoder;
using OnEncodedVideoCB =
base::Callback<void(const scoped_refptr<media::VideoFrame>& video_frame,
@@ -60,8 +61,7 @@ class CONTENT_EXPORT VideoTrackRecorder
blink::WebMediaStreamTrack track_;
// Inner class to encode using whichever codec is configured.
- class VpxEncoder;
- const scoped_refptr<VpxEncoder> encoder_;
+ const scoped_refptr<Encoder> encoder_;
DISALLOW_COPY_AND_ASSIGN(VideoTrackRecorder);
};
« no previous file with comments | « no previous file | content/renderer/media/video_track_recorder.cc » ('j') | content/renderer/media/video_track_recorder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698