Issue 1893363002: Fix selection of "no audio processing" mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1893363002: Fix selection of "no audio processing" mode. (Closed)

Created:
4 years, 8 months ago by hta - Chromium

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Fix selection of "no audio processing" mode. It was only possible to turn it off with a basic (mandatory) constraint. It should also be possible to turn it off with an advanced (optional) constraint. BUG=603900 Review URL: https://codereview.chromium.org/1891953003 Cr-Commit-Position: refs/heads/master@{#387597} (cherry picked from commit d4867880e77f4f8896a781740fff32f379df28b1) Committed: https://chromium.googlesource.com/chromium/src/+/5c23fd07b662dac46924f60da3c4b1cf45a0536c

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -2 lines)			Patch
M	content/renderer/media/media_stream_audio_processor_options.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_processor_options.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/renderer/media/media_stream_audio_processor_unittest.cc	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

hta - Chromium

4 years, 8 months ago (2016-04-18 14:53:34 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5c23fd07b662dac46924f60da3c4b1cf45a0536c.