Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1891953003: Fix selection of "no audio processing" mode. (Closed)

Created:
4 years, 8 months ago by hta - Chromium
Modified:
4 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix selection of "no audio processing" mode. It was only possible to turn it off with a basic (mandatory) constraint. It should also be possible to turn it off with an advanced (optional) constraint. BUG=603900 Committed: https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1 Cr-Commit-Position: refs/heads/master@{#387597}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M content/renderer/media/media_stream_audio_processor_options.h View 1 chunk +5 lines, -0 lines 1 comment Download
M content/renderer/media/media_stream_audio_processor_options.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
hta - Chromium
This should fix it. Holding off on fixing all the other spots to use common ...
4 years, 8 months ago (2016-04-15 13:20:36 UTC) #3
henrika (OOO until Aug 14)
LGTM. Have you been able to verify that the latency values are reducing using this ...
4 years, 8 months ago (2016-04-15 13:36:13 UTC) #5
hta - Chromium
On 2016/04/15 13:36:13, henrika wrote: > LGTM. > > Have you been able to verify ...
4 years, 8 months ago (2016-04-15 13:45:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891953003/1
4 years, 8 months ago (2016-04-15 13:45:39 UTC) #8
tommi (sloooow) - chröme
I just gave it a try and it seems to be working. One suggestion for ...
4 years, 8 months ago (2016-04-15 13:46:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 14:32:51 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 14:34:17 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1
Cr-Commit-Position: refs/heads/master@{#387597}

Powered by Google App Engine
This is Rietveld 408576698