Fix selection of "no audio processing" mode.

Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=603900
Committed: https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1
Cr-Commit-Position: refs/heads/master@{#387597}

[hta - Chromium, 2016-04-15 13:20:02]

Description was changed from

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=
==========

to

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=
==========

[hta - Chromium, 2016-04-15 13:20:02]

hta@chromium.org changed reviewers:
+ henrika@chromium.org, tommi@chromium.org

[hta - Chromium, 2016-04-15 13:20:36]

This should fix it. Holding off on fixing all the other spots to use common
utility functions to a later CL.

[hta - Chromium, 2016-04-15 13:32:59]

Description was changed from

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=
==========

to

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=603900
==========

[henrika (OOO until Aug 14), 2016-04-15 13:36:13]

LGTM.

Have you been able to verify that the latency values are reducing using this
fix?

[hta - Chromium, 2016-04-15 13:45:22]

On 2016/04/15 13:36:13, henrika wrote:
> LGTM.
> 
> Have you been able to verify that the latency values are reducing using this
> fix?

Sorry, no tooling for that, but since you checked that it worked when you forced
the default_audio_processing flag, and the added tests check that flag directly,
we should have a good chance of success.

[hta - Chromium, 2016-04-15 13:45:26]

The CQ bit was checked by hta@chromium.org

[commit-bot: I haz the power, 2016-04-15 13:45:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1891953003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1891953003/1

[tommi (sloooow) - chröme, 2016-04-15 13:46:35]

I just gave it a try and it seems to be working.  One suggestion for how to
modify the public interface of the constraint class, but otherwise lgtm.

https://codereview.chromium.org/1891953003/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_audio_processor_options.h (right):

https://codereview.chromium.org/1891953003/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_audio_processor_options.h:87: bool
default_audio_processing_constraint_value() const {
prefer GetDefaultAudioProcessingConstraintValueForTesting().

the "ForTesting" postfix is the most commonly used indicator used to make sure a
method isn't used by non-test code.

Alternatively, you could make that member variable protected (not private) and
expose it in a derived test class.  That way, the public interface isn't
affected.

[commit-bot: I haz the power, 2016-04-15 14:32:49]

Description was changed from

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=603900
==========

to

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=603900
==========

[commit-bot: I haz the power, 2016-04-15 14:32:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-15 14:34:16]

Description was changed from

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=603900
==========

to

==========
Fix selection of "no audio processing" mode.

It was only possible to turn it off with a basic (mandatory)
constraint. It should also be possible to turn it off with an
advanced (optional) constraint.

BUG=603900

Committed: https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1
Cr-Commit-Position: refs/heads/master@{#387597}
==========

[commit-bot: I haz the power, 2016-04-15 14:34:17]

Patchset 1 (id:??) landed as
https://crrev.com/d4867880e77f4f8896a781740fff32f379df28b1
Cr-Commit-Position: refs/heads/master@{#387597}